Repository navigation
Conversation
|
The latest Buf updates on your PR. Results from workflow Tests / test (pull_request).
|
❌ 3 blocking issues (3 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - uses: actions/checkout@v7 |
| @@ -16,10 +16,10 @@ jobs: | |||
| pull-requests: write | |||
| steps: | |||
| - name: Checkout code | |||
| - name: Set environment variables from .env | ||
| uses: xom9ikk/dotenv@v2.3.0 | ||
| - uses: actions/setup-go@v5 | ||
| uses: xom9ikk/dotenv@v2.4.0 |
There was a problem hiding this comment.
🟡 Changes recommended
The repo’s declared Go version in go.mod is inconsistent with the CI Go version sourced from .env, making the intended minimum/target Go version unclear and prone to drift.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR upgrades the repository’s protobuf/tooling and Go ecosystem to support Protobuf Edition 2024 and newer generator/runtime versions, updating generated Go outputs and CI accordingly.
Changes:
- Migrates protobuf sources from
edition = "2023"toedition = "2024"and regenerates Go code with protoc-gen-go v1.36.12. - Updates Go module dependencies (including
google.golang.org/protobuf) and Buf generation configuration/lockfile. - Updates GitHub Actions workflows and the pinned CI Go version in
.env.
File summaries
| File | Description |
|---|---|
| proto/protoprivacy/boostport/privacy/privacy.proto | Switches protobuf edition to 2024. |
| proto/protoprivacy-testing/boostport/privacy/testing/valid.proto | Switches protobuf edition to 2024 for test protos. |
| proto/protoprivacy-testing/boostport/privacy/testing/test.proto | Switches protobuf edition to 2024 for test protos. |
| proto/protoprivacy-testing/boostport/privacy/testing/passthrough.proto | Switches protobuf edition to 2024 for test protos. |
| proto/protoprivacy-testing/boostport/privacy/testing/invalid.proto | Switches protobuf edition to 2024 for test protos. |
| internal/generated/boostport/privacy/testing/valid.pb.go | Regenerates Go output with updated protoc-gen-go/runtime metadata. |
| internal/generated/boostport/privacy/testing/test.pb.go | Regenerates Go output with updated protoc-gen-go/runtime metadata. |
| internal/generated/boostport/privacy/testing/passthrough.pb.go | Regenerates Go output with updated protoc-gen-go/runtime metadata. |
| internal/generated/boostport/privacy/testing/invalid.pb.go | Regenerates Go output with updated protoc-gen-go/runtime metadata. |
| internal/generated/boostport/privacy/privacy.pb.go | Regenerates Go output with updated protoc-gen-go/runtime metadata. |
| go.sum | Refreshes dependency checksums after upgrades. |
| go.mod | Updates module Go version and dependency versions. |
| buf.lock | Updates Buf dependency lock to a newer commit/digest. |
| buf.gen.yaml | Updates remote protoc-gen-go plugin version and generation options. |
| .github/workflows/tests.yml | Updates action versions and Go setup in CI. |
| .github/workflows/push-to-bsr.yml | Updates checkout action version for publishing workflow. |
| .env | Updates CI Go version value consumed by workflows. |
Review details
- Files reviewed: 10/17 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| module github.com/Boostport/protoprivacy | ||
|
|
||
| go 1.24 | ||
| go 1.25.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.